Issue 51150 - Slideshow ignores digit language
Summary: Slideshow ignores digit language
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: recent-trunk
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: christoph.lukasiak
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2005-06-23 11:28 UTC by thb
Modified: 2007-08-29 16:06 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Bugdoc (9.98 KB, application/vnd.oasis.opendocument.presentation)
2007-05-29 10:26 UTC, thb 		no flags Details
the patch of issue (5.16 KB, patch)
2007-06-21 07:29 UTC, liujl 		no flags Details | Diff
the patch of issue (7.41 KB, text/plain)
2007-06-26 02:29 UTC, liujl 		no flags Details
the patch of issue (7.69 KB, text/plain)
2007-06-27 06:18 UTC, liujl 		no flags Details
the patch of issue (8.42 KB, text/plain)
2007-06-28 09:14 UTC, liujl 		no flags Details
the patch of issue (8.31 KB, text/plain)
2007-07-05 08:02 UTC, liujl 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2005-06-23 11:28:39 UTC 
Please advise: cppcanvas/source/mtfrenderer/implrenderer.cxx has a NYI
META_TEXTLANGUAGE_ACTION. I have no idea how to transport the digit language
across the XCanvas API. Any ideas?
Comment 1 thb 2005-06-23 11:33:30 UTC 
Setting a target.
Comment 2 hdu@apache.org 2005-07-28 13:37:26 UTC 
.
Comment 3 hdu@apache.org 2005-08-25 15:54:36 UTC 
As you already suggested it would be best to have the strings already converted
to use the proper digits. See the function GetLocalizedChar() in
vcl/source/gdi/sallayout.cxx for how to convert the ASCII digits into localized
digits.
Comment 4 thb 2006-01-19 15:41:12 UTC 
Retargetted due to resource constraints.
Comment 5 thb 2006-05-02 13:16:59 UTC 
Retargetted to 2.0.4 due to resource constraints.
Comment 6 thb 2006-07-10 11:54:54 UTC 
Retargetted due to resource constraints
Comment 7 thb 2007-05-29 10:15:54 UTC 
.
Comment 8 thb 2007-05-29 10:26:13 UTC 
Created attachment 45481 [details]
Bugdoc
Comment 9 thb 2007-05-29 11:01:30 UTC 
@liujianli: please have a look at the attached bugdoc. when loading this in a
plain office, the digits should show up as Latin numerals. now go to
tools->options->language settings->complex text layout, and choose 'Hindi' from
the  General Options/Numerals dropdown. Now, the digits should use Hindi
numerals. Fire up a slideshow: now the digits are Latin again.

This is the actual issue.

How to fix this? First, you need to find out who's setting the digit language at
the OutputDevice::SetDigitLanguage(), and whether a metaaction of
META_TEXTLANGUAGE_ACTION appears in the shape metafiles (which get processed in
said cppcanvas/source/mtfrenderer/implrenderer.cxx). After that, you need to
find out how to transport that information across the XCanvas API, or, as hdu
suggested, directly convert the digit characters in the string, before passing
them to the TextAction in implrenderer.cxx
Comment 10 liujl 2007-06-21 07:29:25 UTC 
Created attachment 46129 [details]
the patch of issue
Comment 11 liujl 2007-06-26 02:29:41 UTC 
Created attachment 46241 [details]
the patch of issue
Comment 12 thb 2007-06-26 08:49:24 UTC 
Adapted cc list
Comment 13 liujl 2007-06-27 06:18:35 UTC 
Created attachment 46273 [details]
the patch of issue
Comment 14 liujl 2007-06-28 09:14:55 UTC 
Created attachment 46331 [details]
the patch of issue
Comment 15 liujl 2007-07-05 08:02:43 UTC 
Created attachment 46532 [details]
the patch of issue
Comment 16 thb 2007-07-05 08:44:54 UTC 
Changing target, this should go in asap.
Comment 17 thb 2007-07-05 15:09:43 UTC 
@liujl: thanks for the fix, committed to CVS with only slight adaptations.

Fixed in CWS thbpp8.
Comment 18 thb 2007-07-23 21:13:53 UTC 
@clu: fixed in CWS thbpp8, please verify.
Comment 19 christoph.lukasiak 2007-07-25 13:22:58 UTC 
verified in cws
Comment 20 christoph.lukasiak 2007-08-29 16:06:01 UTC 
verified in master