Issue 28535 - Enter key = copy
Summary: Enter key = copy
Status: ACCEPTED
Alias: None
Product: Calc
Classification: Application
Component: ui (show other issues)
Version: OOo 1.1.1
Hardware: All All
: P3 Trivial with 4 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 107963 (view as issue list)
Depends on:
Blocks:
 
Reported: 2004-04-29 17:35 UTC by jmachado1972
Modified: 2013-07-30 02:36 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Implements the desired behavior. (8.84 KB, patch)
2008-02-07 18:42 UTC, jpryor
no flags Details | Diff
Updated patch. (10.87 KB, patch)
2008-02-22 21:55 UTC, jpryor
no flags Details | Diff
Updated patch. (10.23 KB, text/plain)
2008-03-05 19:33 UTC, jpryor
no flags Details
updated patch (12.38 KB, patch)
2009-07-27 16:12 UTC, kyoshida
no flags Details | Diff
animated border patch (sc) (15.66 KB, patch)
2009-07-27 16:13 UTC, kyoshida
no flags Details | Diff
animated border patch (svx) (819 bytes, patch)
2009-07-27 16:14 UTC, kyoshida
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description jmachado1972 2004-04-29 17:35:03 UTC
It would be nice, if we could use the enter key, as a shortcut, to paste
something from the clipboard.
Comment 1 frank 2004-04-30 09:04:53 UTC
Hi Bettina,

one for you.

Frank
Comment 2 insac 2005-01-19 10:48:49 UTC
I've installed Oo in my father's computer. The only complaint I got so far is
about this "enhancement", since he was used to "another spreadsheet" behaviour.

I vote for this issue
Comment 3 jpryor 2008-02-07 18:42:04 UTC
Created attachment 51424 [details]
Implements the desired behavior.
Comment 4 jpryor 2008-02-07 18:44:42 UTC
An analysis of the "other" spreadsheet shows that:

1. ENTER as an alias for paste only occurs if you copy something within the
spreadsheet first.  Copying text to the clipboard from another application does
not cause ENTER to be an alias.

2. ENTER only works as an alias the *first* time it's pressed after the copy.

3. After using ENTER in this fashion, the clipboard is cleared.

The previously attached patch implements all of these behviors.
Comment 5 jpryor 2008-02-22 21:55:41 UTC
Created attachment 51674 [details]
Updated patch.
Comment 6 jpryor 2008-02-22 23:56:30 UTC
The updated sc-paste-on-enter.diff removes some crashes that were present in the
previous patch, and alters the behavior so that after the paste the destination
cell doesn't have a black background with white text.

However, I've noticed that ooh680-m7 removes this "black backround/white text"
on Ctrl+V (paste) display issue, so I'm not sure if that part is necessary anymore.
Comment 7 jpryor 2008-03-05 19:33:22 UTC
Created attachment 51918 [details]
Updated patch.
Comment 8 jpryor 2008-03-05 19:35:12 UTC
The most recent updated patch uses ScTabView::Unmark() instead of the (hackish)
addition of an IDF_SPECIAL_NOMARKAREA flag.  It also allows TAB to move the
current cell if only a single cell was pasted (instead of TAB moving "between"
the cells of the pasted selection, which doesn't do anything as there's only one
cell in the selection).
Comment 9 kyoshida 2009-07-27 16:12:28 UTC
Created attachment 63804 [details]
updated patch
Comment 10 kyoshida 2009-07-27 16:13:55 UTC
Created attachment 63805 [details]
animated border patch (sc)
Comment 11 kyoshida 2009-07-27 16:14:25 UTC
Created attachment 63806 [details]
animated border patch (svx)
Comment 12 kyoshida 2009-07-27 16:15:59 UTC
The last two patches are for implementing animated borders around pasted ranges.
Comment 13 kyoshida 2009-10-06 00:01:15 UTC
I've opened up Issue 105628 for supporting animated borders for copied range.
Comment 14 kyoshida 2009-10-06 00:01:48 UTC
re-assigning this to myself.
Comment 15 kyoshida 2009-10-06 00:02:04 UTC
started.
Comment 16 kyoshida 2009-10-06 00:02:43 UTC
The work is on-going in the koheicopyborder cws.
Comment 17 andrewabc 2009-10-31 03:24:13 UTC
Is there a way to disable paste on enter key input and keep copied cells in
clipboard?

I find myself copying a cell, then I double click on another cell to check out a
formula, and press enter when I'm done looking at it and it pastes a cell
location into the formula and messes it all up.

In windows version this does not happen and it remembers copied cells on
clipboard if I double click and press enter on a cell.

An option to disable this would be much appreciated.

Combine this with the undo crash bug (that is now fixed) and I've wasted hours
on crashed spreadsheets and being very afraid to use undo function, luckily
recovery works good.
Comment 18 kyoshida 2009-10-31 03:31:07 UTC
That's what I just fixed in Issue 102456.
Comment 19 andrewabc 2009-10-31 15:02:20 UTC
Yes you fixed the undo crash bug.
But it would still paste on enter button input wont it? I want that disabled.
Although this bug report seems to indicate back in 2004 that someone wanted it
enabled (press enter and it pastes content).

"I find myself copying a cell, then I double click on another cell to check out a
formula, and press enter when I'm done looking at it and it pastes a cell
location into the formula and messes it all up."
Comment 20 kyoshida 2009-10-31 16:05:40 UTC
>But it would still paste on enter button input wont it?

No.  Like I said, that was the bug causing the undo stack corruption, and I
fixed it.
Comment 21 kyoshida 2009-10-31 16:16:45 UTC
To be more specific, when you go into an input mode (i.e. double-click on a cell
so that the blinking cursor is displayed), the paste-on-enter functionality is
supposed to be disabled.  So, in your use case, it will not paste when the enter
key is pressed.
Comment 22 andrewabc 2009-10-31 16:36:40 UTC
Ok Thanks.

Glad two bugs were fixed (didn't know they were related) :)
Hope they make it into the next openoffice version. Should 'target milestones'
be set?
Comment 23 kyoshida 2009-10-31 18:49:05 UTC
My tentative target is 3.3 although I have several other features targeting for
3.3 and I'm not sure if I can make this one integrated in time for 3.3.  But
I'll set the target later when I feel appropriate.
Comment 24 kyoshida 2009-12-28 15:03:58 UTC
*** Issue 107963 has been marked as a duplicate of this issue. ***
Comment 25 ivosir 2010-01-06 11:34:29 UTC
Hi all,

I would opt for an option to disable the "paste on enter key" feature. IMHO it
is inconsistent with other functionalities.

The "enter to switch to edit mode"; I like this option very much, am used to it.
But together with the "paste on enter key" this gets very confusing:

1) CTRL+C - copy a cell to the clipboard
2) CTRL+V - paste the clipboard somewhere (another cell or even another
application) and forget about it, continue working on something else
3) back to the spreadsheet, press ENTER to edit another cell not related to the
previous one... and voila, the cell gets overwritten by the very first one

Personally I am struggling with this trouble each and every day...

Many thanks,
Ivo
Comment 26 kyoshida 2010-01-06 12:47:04 UTC
You can hit ESC to manually exit the paste mode.
Comment 27 Rob Weir 2013-03-11 15:01:18 UTC
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob
Comment 28 Rob Weir 2013-07-30 02:36:46 UTC
Reset assignee on issues not touched by assignee in more than 1000 days.