Apache OpenOffice (AOO) Bugzilla – Issue 86377
Cell number format commands should be toggle-able much like the bold, italic buttons
Last modified: 2013-03-11 14:58:37 UTC
There are 6 cell number format toolbar buttons (currency, percent, date, scientific, time and the standard) that apply their respective cell format when pressed. But compared to the other formatting buttons such as the bold, italic, underline, and the alignment buttons, these number format buttons are not toggle-able. The patch I will attach shortly will make them toggle-able to make them behave consistently with the rest of the cell format buttons. The patch will also remove the standard format since that's no longer needed.
cc'ing fl for usability input.
Created attachment 51672 [details] proposed patch
issue type PATCH
This needs user Experience input, especially removing the "Standard" button. The handling of multiple cells in the patch (just using the cursor position) is different from other format buttons.
Created attachment 55663 [details] update patch
The new patch handles the state of a number format on a cell range the same way as how a font attribute state is decided.
Created attachment 55730 [details] update patch to fix a crash bug (i#92703).
The standard format button is needed for reset Add/Delete decimal place. So it should not be removed.
@adajun: right-clicking on a cell and selecting the 'Default Formatting' does the same thing as the Standard button. I personally don't think it warrants an extra icon since the functionality is available from the context menu.
No, context menu > "Default Formatting" removes hard formatting but the assigned cell style remains. The "standard format" button sets a hard formatting. You can easily see the difference if you define a cell style with a science format of 15 digits, for example. I need the "standard format" button, do not remove it.
@kohei:It is not same, for example "Default Formatting" removes border setting too. Right-clicking on a cell and select the 'Format cells' and select Numbers tab and Number in category and General in Format. It is difficult to select the suitable item in Format cells for beginners. If it is able to set using toolbar button, then it should be able to unset using toolbar button. It is very important thing for usability.
Created attachment 57370 [details] revised patch
Ok, fair argument. I've revised my patch to revive the standard button but made invisible by default. The button can be easily turned on via toolbar's 'Visible Buttons' properties. By the way, >If it is able to set using toolbar button, then it should be able to unset using toolbar button. this is what my toggle-able format button does. Setting it will set the respective cell format, and pressing the same button again will set the cell format back to the standard. So, what you said above is already taken into consideration (hence the argument for removing the standard button).
Thank you for accepting. Toggle-able format buttons are easy to understand, I think. But to use Add decimal place button or Delete decimal place button we needs standard format button. Two problems are remained. 1. The icon of standard format button is designed for reset currency and percent setting. We can see $ and % and arrow in it. It has still the function, but it does not match to toggle-able button. 2. It same to windows version ? I do not use 3.0 yet. OOo2.4.1 for windows has non toggle-able buttons.
>1. The icon of standard format button is designed for reset > currency and percent setting. We can see $ and % and arrow in it. > It has still the function, but > it does not match to toggle-able button. Well, icon design is a separate issue. Since the standard icon is used like that today, I don't see the urgent need to change its design. (IMO the icon should be symbolic of what it does, but it's hard to be "accurate" with its design.) >2. It same to windows version ? I do not use 3.0 yet. > OOo2.4.1 for windows has non toggle-able buttons. Ah, you must be new here. :-) See the status of this issue (NEW), and the target milestone not being set. That means this patch has not been accepted yet. In other words, this functionality is not available in any versions you can download from the official site.
>icon design is a separate issue. I see. I hope someone make it to be accurate too :-) >you must be new here Yes, sorry. I realized after send. Debian's OOo2.4.1 is toggle-able already, so I misunderstand.
@kohei maybe you can take a look at issue [[http://qa.openoffice.org/issues/show_bug.cgi?id=8443|8443]], as it is also about a toggle-able enhancement. Thanks.
I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob