Issue 77236 - Can split merged cells in protected sheet
Summary: Can split merged cells in protected sheet
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: OOo 2.2
Hardware: PC Windows XP
: P3 Trivial (vote)
Target Milestone: ---
Assignee: frank
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2007-05-11 09:25 UTC by pmike
Modified: 2013-08-07 15:14 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The patch file of about i77236# (1.54 KB, text/plain)
2007-10-18 03:39 UTC, yonggang.mao 		no flags Details
The patch of about issue77236#. (2.38 KB, text/plain)
2007-10-18 15:08 UTC, yonggang.mao 		no flags Details
The patch file of about i77236#-v3 (882 bytes, text/plain)
2007-10-25 08:27 UTC, yonggang.mao 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pmike 2007-05-11 09:25:06 UTC 
1. Create empty spreadsheet doc
2. Merge some cells
3. Protect current sheet
4. Un-merge (split) operation is allow, but it should not.
Comment 1 crolidge 2007-05-11 19:40:48 UTC 
Confirmed this behaviour in OOo 2.2 in Windows XP.

If you undo (Ctrl+Z) it will undo anything, including a protection of sheet.
Perhaps this is as intended, because if you save the document and then open it,
then it is really protected. So I don't think this is an error.

Can an expert comment on my commment ??  :)
Comment 2 paul.m.nz 2007-05-14 02:54:58 UTC 
Confirmed this behaviour in OOo 2.2 on Windows 2000.

I think the OP was not meaning Ctrl+Z to do step 4, but you can also use the
tool bar icon to un-merge the cells.

This should not be possible while the sheet is protected.
Comment 3 paul.m.nz 2007-05-14 02:55:26 UTC 
Confirmed this behaviour in OOo 2.2 on Windows 2000.

I think the OP was not meaning Ctrl+Z to do step 4, but you can also use the
tool bar icon to un-merge the cells.

This should not be possible while the sheet is protected.
Comment 4 paul.m.nz 2007-05-17 03:24:24 UTC 
Have changed to 'new' - issue confirmed.
Comment 5 frank 2007-07-06 13:25:30 UTC 
Hi Niklas,

seems to be your construction site. Unmerging works and merging brings up
protected cells warning. Should be the same in both cases.

Frank
Comment 6 yonggang.mao 2007-10-18 03:39:48 UTC 
Created attachment 48989 [details]
The patch file of about i77236#
Comment 7 kpalagin 2007-10-18 08:44:16 UTC 
maoyg,
I suggest changing issue type to "patch".
Comment 8 niklas.nebel 2007-10-18 11:01:49 UTC 
Similar to merging, unmerging of unprotected cells should still be allowed.
Comment 9 yonggang.mao 2007-10-18 15:08:31 UTC 
Created attachment 49004 [details]
The patch of about issue77236#.
Comment 10 yonggang.mao 2007-10-18 15:10:57 UTC 
Hello Niklas,
Please review the latest patch,thanks!
Comment 11 niklas.nebel 2007-10-24 09:11:22 UTC 
Checking the protection of a single cell isn't enough, unmerging can also handle
larger cell ranges. Also, merging shows an error message when called for
protected cells. Unmerging should probably do the same.
Comment 12 yonggang.mao 2007-10-25 08:27:26 UTC 
Created attachment 49141 [details]
The patch file of about i77236#-v3
Comment 13 yonggang.mao 2007-10-25 08:28:46 UTC 
Hello Niklas,
This problems have been solved.
Please review the patch,thanks!
Comment 14 niklas.nebel 2007-10-31 20:17:56 UTC 
The last patch is good, I added it to CWS "calc45".
Comment 15 niklas.nebel 2007-12-03 15:50:38 UTC 
back to QA for verification
Comment 16 frank 2007-12-07 15:10:09 UTC 
found fixed on cws calc45 using Solaris, Linux and Windows build
Comment 17 frank 2008-02-14 10:56:33 UTC 
found integrated on master OOHm5 using Solaris, Linux and Windows build