Issue 72119 - Images in Addons.xcu should be queried every time - not only for addons
Summary: Images in Addons.xcu should be queried every time - not only for addons
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: joerg.skottke
QA Contact: issues@api
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2006-11-30 09:04 UTC by tobiaskrais
Modified: 2013-02-24 21:08 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The changes are in two files: toolbarmanager.cxx and its header file. (2.73 KB, patch)
2007-07-10 04:12 UTC, liangweike 		no flags Details | Diff
Demo add-on to test the new support for add-on images (69.64 KB, application/octet-stream)
2007-07-12 10:19 UTC, carsten.driesner 		no flags Details
Basic script to test the new support for add-on images for menus&toolbars (5.70 KB, text/plain)
2007-07-12 10:20 UTC, carsten.driesner 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tobiaskrais 2006-11-30 09:04:08 UTC 
I wrote a CommanURL and added a picture to the .uno.pkg. This picture is not
shown in the menu if I only add it transient and use the Addons.xcu posted
below. If I add it through the Addons.xcu to the toolbar or menu, the picture is
shown.

Here is my Addons.xcu (with this one, no image is shown)
-----%<----
<?xml version='1.0' encoding='UTF-8'?> 
<oor:component-data xmlns:oor="http://openoffice.org/2001/registry" 
	xmlns:xs="http://www.w3.org/2001/XMLSchema" oor:name="Addons" 
	oor:package="org.openoffice.Office"> 
  <node oor:name="AddonUI">
    <node oor:name="Images">
      <node oor:name="de.twc.oocom.components.saveto.JudasSaveToComponent"
          oor:op="replace">
	<prop oor:name="URL" oor:type="xs:string">
	  <value>.JudasSaveTo:</value>
	</prop>
	<prop oor:name="ImageIdentifier" oor:type="xs:string">
	  <value>%origin%/JudasSaveto</value>
	</prop>
      </node>
    </node>
  </node>
</oor:component-data>
-----%<-----
Comment 1 carsten.driesner 2006-12-01 13:13:47 UTC 
cd: Confirmed and accepted. It's a valid use case that someone wants to extend
the image base with extensions (Addons.xcu). Therefore the UI elements
(menubar/toolbar/statusbar) should also query the addon image repository.
Comment 2 liangweike 2007-07-10 04:12:16 UTC 
Created attachment 46666 [details]
The changes are in two files: toolbarmanager.cxx and its header file.
Comment 3 carsten.driesner 2007-07-11 15:26:18 UTC 
cd: Set issue to patch.
Comment 4 carsten.driesner 2007-07-12 10:19:33 UTC 
Created attachment 46717 [details]
Demo add-on to test the new support for add-on images
Comment 5 carsten.driesner 2007-07-12 10:20:37 UTC 
Created attachment 46718 [details]
Basic script to test the new support for add-on images for menus&toolbars
Comment 6 carsten.driesner 2007-07-12 10:21:24 UTC 
cd: Patch accepted and integrated into CWS fwk68. Fixed.
Comment 7 carsten.driesner 2007-07-13 13:38:25 UTC 
cd->jsk: Please verify.

To verify 

1. Install the extension (DemoAddon_cpp.oxt) first.
2. Copy the Basic script to the Basic IDE
3. Open a new Writer document
4. Run the macro using the menu "Tools - Macro - Run Macro..."
5. You should see a new button at the end of the Standard bar with the same
image as the add-on toolbar (white gulls on a blue background).
6. Open the File menu and you should see a new entry at the end of the menu
called "No image!". It should have an image in front same as the new button.
Comment 8 joerg.skottke 2007-07-19 07:45:13 UTC 
Verified for Windows, Solaris (Sparc) and Linux
Comment 9 joerg.skottke 2007-10-31 11:12:42 UTC 
close