Issue 70671 - Wrong display in pages view
Summary: Wrong display in pages view
Status: CLOSED IRREPRODUCIBLE
Alias: None
Product: Draw
Classification: Application
Component: ui (show other issues)
Version: OOo 2.0.4
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: groucho266
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2006-10-20 21:42 UTC by e7
Modified: 2008-12-06 20:23 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The file contains the changes made for this issue. (2.22 KB, patch)
2007-11-05 06:01 UTC, liangweike 		no flags Details | Diff
It is added in order to avoid view-updating problems. (2.10 KB, patch)
2008-05-14 04:43 UTC, liangweike 		no flags Details | Diff
Some code is modified as an improvement. (2.63 KB, patch)
2008-05-20 08:27 UTC, liangweike 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description e7 2006-10-20 21:42:55 UTC 
Create a new Draw document. Change page direction (--> menu) from portrait to
landscape.  In the list with all pages the pages are redrawn and changed to
landscape, too.  Now press CTRL+Z to undo the change.  The list with all pages
isn't refreshed - the display is wrong...

And now sorry for my bad English, currently I haven't any English version of
OpenOffice available...
Comment 1 wolframgarten 2006-10-24 08:32:21 UTC 
Thanks, reproducible. Your english is quite good understandable.
Reassigned.
Comment 2 groucho266 2006-10-24 11:54:26 UTC 
Accepted.
Comment 3 liangweike 2007-11-05 06:01:51 UTC 
Created attachment 49416 [details]
The file contains the changes made for this issue.
Comment 4 liangweike 2007-11-05 06:11:42 UTC 
First we can take a look at the below snippet of method's calls within call 
stack.
...SdPageFormatUndoAction::Undo()->SdPage::SetSize(...)->SdrPage::SetSize(...)-
>SdrPage::SetChanged()->SdrPage::ActionChanged()...
And SlideSorterView::ModelHasChanged(void) will be invoked after 
SdrPage::ActionChanged(). In this method the controller did not make the model 
adapt its size so that the slidesorterview could not update its page borders 
accordingly and correctly. So we should start with this to solve the problem. 
The proper approach is to lock the controller first and then force it to handle 
the model's change.
Comment 5 liangweike 2007-11-05 06:16:50 UTC 
liangweike->af: Thank you for your help.
Comment 6 groucho266 2007-12-13 16:40:50 UTC 
Fixed by liangweike
Comment 7 groucho266 2007-12-13 16:43:16 UTC 
Please verify.
Comment 8 wolframgarten 2008-01-02 12:59:58 UTC 
Verified in CWS as a stand-in for cgu.
Comment 9 liangweike 2008-05-14 04:43:40 UTC 
Created attachment 53606 [details]
It is added in order to avoid view-updating problems.
Comment 10 liangweike 2008-05-20 08:27:57 UTC 
Created attachment 53785 [details]
Some code is modified as an improvement.
Comment 11 groucho266 2008-11-20 13:56:41 UTC 
Reopening issue as preparation for migration to cws impress164.
Comment 12 groucho266 2008-11-20 13:57:26 UTC 
Changing target to OOo3.1
Comment 13 groucho266 2008-11-20 13:58:36 UTC 
In DEV300 m34 this seems to work as expected.
Comment 14 Mechtilde 2008-12-06 20:23:03 UTC 
worksforme -> closed