Issue 64391 - Column of complex table can be dragged out of view
Summary: Column of complex table can be dragged out of view
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 2.0.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: oooqa
: 55794 65927 (view as issue list)
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2006-04-14 02:53 UTC by zhipengzhang
Modified: 2013-08-07 14:43 UTC (History)
6 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
before change column's width (43.90 KB, image/jpeg)
2006-04-14 02:54 UTC, zhipengzhang 		no flags Details
after change column's width (15.77 KB, image/gif)
2006-04-14 02:55 UTC, zhipengzhang 		no flags Details
patch file (1.27 KB, text/plain)
2007-12-12 06:54 UTC, jian.li 		no flags Details
patch 2 for this issue (1.71 KB, text/plain)
2008-01-03 07:09 UTC, jian.li 		no flags Details
patch III for this issue (1.63 KB, text/plain)
2008-01-09 08:52 UTC, jian.li 		no flags Details
patch 4 (2.02 KB, text/plain)
2008-01-10 02:01 UTC, jian.li 		no flags Details
bugdoc (7.42 KB, application/vnd.oasis.opendocument.text)
2008-02-05 09:09 UTC, frank.meies 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description zhipengzhang 2006-04-14 02:53:56 UTC 
1 insert a 3*3 table
2 change the columns' width to 9.39cm, 1.94cm and 5.67cm
3 merge cell C2 and C3
4 change the column by mouse such the attachment "before.jpg"
5 find the table is wrong such attachment "after.gif"
Comment 1 zhipengzhang 2006-04-14 02:54:47 UTC 
Created attachment 35692 [details]
before change column's width
Comment 2 zhipengzhang 2006-04-14 02:55:16 UTC 
Created attachment 35693 [details]
after change column's width
Comment 3 lars 2006-04-14 11:43:34 UTC 
confirmed with 680_m162 on WinXP Pro SP2
Comment 4 michael.ruess 2006-04-18 14:07:28 UTC 
MRU->OS: as described, create a 3x3 table, merge cells C2 and C3. Then drag
(with mouse) the left column's border close to its right border. The vertical
border of A2.2.1:A2.2.2 seems to be moved right over the page border.
Comment 5 Oliver Specht 2006-06-20 14:20:38 UTC 
Target adjusted and reassigned
Comment 6 Martin Hollmichel 2007-09-10 14:10:04 UTC 
move to target 3.x according http://wiki.services.openoffice.org/wiki/Target_3x
Comment 7 jian.li 2007-12-03 03:02:23 UTC 
lijian->fme:
This issue has not existed since (maybe) m223 which uses new table.
Please check this.
Comment 8 frank.meies 2007-12-03 05:59:47 UTC 
fme->lijian: Anyway, the 'old' table model will still be used if you create a
table with an old version of OOo. So you have to create a bugdoc with an older
version.
Comment 9 jian.li 2007-12-03 06:46:57 UTC 
lijian->fme:
So I will work on this issue. :-)
Comment 10 jian.li 2007-12-12 06:54:58 UTC 
Created attachment 50254 [details]
patch file
Comment 11 jian.li 2007-12-12 06:56:46 UTC 
lijian->fme:
Please have a look at this patch. Thank you !
Comment 12 frank.meies 2007-12-12 11:15:27 UTC 
fme->lijian: I like your idea that the first box in the last line of an upper
cell takes care that the upper cell remains in the array. But your code
currently does only work if the left table border has been moved. But the whole
scenario might take place somewhere in the middle of a table.
Comment 13 jian.li 2008-01-03 07:09:01 UTC 
Created attachment 50636 [details]
patch 2 for this issue
Comment 14 jian.li 2008-01-03 07:14:34 UTC 
lijian->fme:
Please review this patch. Basically I still want the first box in the last 
line of an upper cell taking care that the upper cell remains in the array.I 
have changed the condition on removing the upper cell from the array. It seems 
OK now. Waiting for your suggestions.
Comment 15 jian.li 2008-01-09 08:52:00 UTC 
Created attachment 50756 [details]
patch III for this issue
Comment 16 jian.li 2008-01-09 08:54:43 UTC 
lijian->fme:
For this patch, I have tested some more nesting examples. For the moment, 
I found everything OK. Please review this patch, and give me your reply :-)
Comment 17 frank.meies 2008-01-09 10:12:07 UTC 
fme->lijian: Thank you for your patch. Looks good but please test if thoroughly.
One more remark: I think the code adjusting nDiff at the end of the while loop
can be moved to the 'else' case.
Comment 18 jian.li 2008-01-09 13:41:44 UTC 
lijian->fme:
Yes,the code adjusting nDiff should be moved to the 'else' case.
And then ? I just need to test this code more and more, until we 
can confirm that all is OK ? Actually I have debugged this as
many as possible today.
Comment 19 frank.meies 2008-01-09 14:22:04 UTC 
fme->lijian: Ok, in this case I think we can consider this 'fixed'. I'll
integrate this in a OOo 3.0 cws. Thank you for your help.
Comment 20 jian.li 2008-01-10 02:01:47 UTC 
Created attachment 50775 [details]
patch 4
Comment 21 jian.li 2008-01-10 02:06:19 UTC 
lijian->fme:
I have put the code adjusting nDiff into the else case.
Thank you for your help. :-)
Comment 22 frank.meies 2008-01-10 08:27:11 UTC 
Fixed in swtable.cxx, cws sw30bf01. Thank you for your help.
Comment 23 frank.meies 2008-02-05 09:09:22 UTC 
Created attachment 51373 [details]
bugdoc
Comment 24 frank.meies 2008-02-05 09:10:27 UTC 
Only reproducible with the 'old' table model. Attached new bugdoc. 

Ready for QA.
Comment 25 michael.ruess 2008-03-12 09:52:24 UTC 
Verified in CWS sw30bf01.
Comment 26 frank.meies 2008-04-03 07:11:40 UTC 
*** Issue 65927 has been marked as a duplicate of this issue. ***
Comment 27 frank.meies 2008-04-03 07:15:40 UTC 
*** Issue 55794 has been marked as a duplicate of this issue. ***
Comment 28 michael.ruess 2008-06-05 08:53:00 UTC 
Works fine in DEV300m14.