Issue 53545 - Applying changes to the cell format should overrule independently formatted parts (Edit cells)
Summary: Applying changes to the cell format should overrule independently formatted p...
Status: CONFIRMED
Alias: None
Product: Calc
Classification: Application
Component: formatting (show other issues)
Version: 680m99
Hardware: All All
: P3 Trivial with 15 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 57902 63190 75350 90102 92876 93642 94113 95735 96853 101188 101189 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-08-19 13:25 UTC by stp
Modified: 2013-08-07 15:13 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
a proposed patch (31.02 KB, patch)
2008-08-22 00:38 UTC, kyoshida
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description stp 2005-08-19 13:25:13 UTC
This works as expected:
1. Open new sheet
2. Select cell A1
3. Type something on the keyboard and press Enter
4. Select cell A1 again
5. Change font color and note that the color changes as expected

This will break font color changing:
1. Open new sheet
2. Select cell A1
3. Type something BUT don't press Enter
4. Mark the typed text with the caret
5. Change color and note the the color changes as expected
6. Deselct cell A1
7. Select (single click) cell A1 again
8. Try and change font color and note the color doesn't change

I spotted this bug when pasting HTML with colored text also.
Comment 1 frank 2005-09-13 10:49:09 UTC
Hi,

this is not a bug but a feature from Calc. You can independently give formats to
parts of a cell or to the whole one. Making an Edit cell as it is called if you
set the formats independently for parts of the text overrules the cell
formatting. So this is intentional and mostly what the user wants.

Frank
Comment 2 frank 2005-09-13 10:49:53 UTC
closed invalid
Comment 3 stp 2005-09-14 14:03:31 UTC
Applying format to part of the cell overrules cell format. Agree.

Now please consider carefully the vice versa - ie. whether applying changes to
the cell format should overrule independently formatted parts.

Adjusted summary.

I encourage you to reopen and assign to requirements.
Comment 4 frank 2005-09-27 10:51:03 UTC
Hi,

that's not a good idea. Think about a text with about 100 words, 50 are
independently formatted (bold, underline, font height, font, color ...) now
you've selected this cell and apply by accident a numberformat making this cell
to carry a white font color. As you are in a hurry you save the document
directly after that and sometimes later you re-open it. All the text in this
particulary cell seems to be gone. Not a good impression.

As it is easy to get a cell with independently formated text back to one with
default format (just open the context menu and choose default) I will leave this
Issue closed.

Frank
Comment 5 frank 2005-11-15 09:33:51 UTC
*** Issue 57902 has been marked as a duplicate of this issue. ***
Comment 6 frank.loehmann 2005-11-15 17:02:49 UTC
FL->TZ: I still consider this behavior a bug for the following reasons:
- Calc behaves different than any other program (including those from the
competition).
- The current behavior is illogical:
   - i.e. copy & paste from other documents (i.e. text from Writer) often mixes
up the formatting in Calc cells if not inserted as plain text (which is not the
default). Currently the user could not correct these formats (i.e. the font type
and size) without resetting _all_ other formatting (like bold, italic, etc.) by
choosing Format – Default formatting before, because assigning the font type and
size to a selection of cells does not change the attribute if there were any
direct attributes on single characters of the cell. 
   - and there is no advantage in keeping behaving 

Especially when using Calc as a tool for processing textual input, i.e. to
create and prioritize a feature list, this leds to tables with different
formatting in several cells of the document. I have seen this in many of those
documents used for planning our product, but first I thought that those issues
were errors, before I got the point why this occurs.
Comment 7 frank.loehmann 2005-11-15 17:03:42 UTC
FL->TZ: Please decide.
Comment 8 frank.loehmann 2005-11-15 17:04:17 UTC
change target
Comment 9 thorsten.ziehm 2006-01-23 13:20:24 UTC
A comparison with a competitor shows me, in spreadsheet it works different as in
other products. I would say, that the following is a bug, which should be adressed.
- write some word as text in cell A1
- mark one word and change the color
- deselect the cell A1
=> now you got a mixture in the text of default color and a preselected color in
this cell
- select the cell A1 (only selection, not in edit mode)
- select a different color for the cell
=> only the text with default color changed the color, the other text keep the
preselected color
When the cell is selected, the formats should be taken by all text in this cell
and not only by the text with the default color.

=> FST : Please bring this issue to the correct developer. Thx.
Comment 10 niklas.nebel 2006-01-23 16:41:58 UTC
Formatted text is part of cell content, not cell formats. It has to be that way
(you can't include single character formats when copying cell formats between
cells with different text, for example).

Individual functions could be changed to also modify formatted text (like
"Default Formatting" already does), but that would be
1) an enhancement, not a bug fix,
2) perpetually inconsistent with other functions.
Comment 11 frank 2006-02-07 12:26:25 UTC
Hi Frank,

please get in contact with Niklas and provide a spec if necessary.

Frank
Comment 12 frank 2006-03-15 11:37:02 UTC
*** Issue 63190 has been marked as a duplicate of this issue. ***
Comment 13 frank.loehmann 2006-07-13 16:55:46 UTC
set target to OOo 2.x
Comment 14 frank 2007-03-13 10:35:33 UTC
*** Issue 75350 has been marked as a duplicate of this issue. ***
Comment 15 zhipengzhang 2007-03-14 02:29:01 UTC
This bug is not carsh, but it block user to use openoffice severely

It is a very usual function, almost all user will use it
so its priority should be P1
Comment 16 lily_chu 2007-03-15 09:29:08 UTC
we must respect the user's habbit.
Comment 17 frank.loehmann 2007-09-06 21:58:44 UTC
Set target to Ooo 3.0.
Comment 18 frank.loehmann 2008-02-11 15:45:05 UTC
FL: No resources for 3.0 -> 3.x
Comment 19 frank 2008-08-20 09:13:47 UTC
*** Issue 92876 has been marked as a duplicate of this issue. ***
Comment 20 kyoshida 2008-08-22 00:38:03 UTC
Created attachment 55920 [details]
a proposed patch
Comment 21 kyoshida 2008-08-22 00:49:25 UTC
So, this is a hairy issue.  Calc doesn't behave like what the end users expect,
but internally the formatted texts are handled by the edit engine which is
somewhat independent from the Calc code.

Anyway, the attached patch is my solution to this.  Fixing the run-time behavior
was somewhat simple, but the xls and ods import filters expected this behavior,
so my change ended up breaking the import filters.  I worked around it by
keeping the current behavior while importing document.  The correct fix would be
to fix both import filters, but I didn't want to risk breaking other things by
doing so.

The patch is from ooo-build.  So far it's been working good, but I welcome your
comments.
Comment 22 kyoshida 2008-08-22 00:59:04 UTC
*** Issue 90102 has been marked as a duplicate of this issue. ***
Comment 23 yonggang.mao 2008-09-11 08:36:32 UTC
*** Issue 93642 has been marked as a duplicate of this issue. ***
Comment 24 frank 2008-09-22 08:49:22 UTC
*** Issue 94113 has been marked as a duplicate of this issue. ***
Comment 25 corigo 2008-10-01 11:01:21 UTC
In 3.0 RC3 when I select a cell with partial content in another color as 
follows: 
------------start cell ---
Normal format text
Special format text
Normal format text
------------end cell ---
Then I click on the Bold button (for example) only the text before the special 
format text is now bold. The normal format text after is still normal. It has 
not been effected by the command to bold.
Comment 26 frank 2008-11-01 14:20:35 UTC
*** Issue 95735 has been marked as a duplicate of this issue. ***
Comment 27 kyoshida 2008-12-04 00:40:09 UTC
*** Issue 96853 has been marked as a duplicate of this issue. ***
Comment 28 Regina Henschel 2009-04-18 22:51:58 UTC
*** Issue 101189 has been marked as a duplicate of this issue. ***
Comment 29 vseredkine 2009-04-27 02:46:41 UTC
I can reproduce that on system Windows XP with version OOO310m9 (build:9396).
Comment 30 Regina Henschel 2009-05-06 21:20:34 UTC
*** Issue 101188 has been marked as a duplicate of this issue. ***
Comment 31 Rob Weir 2013-03-11 15:01:45 UTC
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob