Issue 50825 - Datapilot: Pagefileds and filter option overwrite source area
Summary: Datapilot: Pagefileds and filter option overwrite source area
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: ui (show other issues)
Version: recent-trunk
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2005-06-16 13:53 UTC by peter.junge
Modified: 2013-08-07 15:14 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
use this document to reproduce (5.78 KB, application/vnd.sun.xml.calc)
2005-06-16 13:55 UTC, peter.junge 		no flags Details
Update the patch. (522 bytes, text/plain)
2009-04-29 10:00 UTC, yonggang.mao 		no flags Details
Update the patch. (1.17 KB, text/plain)
2009-05-07 05:02 UTC, yonggang.mao 		no flags Details
Update the patch again. (1.58 KB, text/plain)
2009-05-11 03:34 UTC, yonggang.mao 		no flags Details
Update the patch. (2.78 KB, text/plain)
2009-05-15 04:56 UTC, yonggang.mao 		no flags Details
Update the patch. (2.84 KB, text/plain)
2009-05-20 15:49 UTC, yonggang.mao 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description peter.junge 2005-06-16 13:53:04 UTC 
open attached document
start datapilot
Area -> Column
Salesman -> Row
2000 -> Data
click more
disable 'Add filter'
OK
restart dataplilot
case 1: check 'Add filter'
case 2: drop Products -> Page
OK
-> line 21 get's overwritten
Comment 1 peter.junge 2005-06-16 13:55:07 UTC 
Created attachment 27238 [details]
use this document to reproduce
Comment 2 niklas.nebel 2005-06-16 14:17:12 UTC 
It's intended (and specified) that way: "If the number of page fields in an
existing DataPilot table is changed, the table's start position on the sheet is
moved up or down, so the area with the column/row fields and data (with the
thick border) starts at the same position."
(http://specs.openoffice.org/calc/compatibility/pagefields.sxw).
Comment 3 peter.junge 2005-06-16 14:34:33 UTC 
Sorry, then the specification got to be changed because after a refresh of the
datapilot the results are messed up.
Reassigned to spec owner.
Comment 4 niklas.nebel 2006-01-23 13:05:43 UTC 
This doesn't seem all that important, so the target can be changed to 3.0.
Comment 5 yonggang.mao 2009-04-09 07:59:44 UTC 
Niklas:I have seen the spec and issue's comment,when I restart dataplilot 
again,click OK button,the calc will popup a dialog,the dialog text is "the 
destination range is not empty.Overwrite existing contents?".I think it is not 
a problem from above text.Do you think about it?
Comment 6 yonggang.mao 2009-04-13 09:57:54 UTC 
taking the issue.
Comment 7 yonggang.mao 2009-04-13 09:59:37 UTC 
Started.
Comment 8 yonggang.mao 2009-04-29 10:00:34 UTC 
Created attachment 61879 [details]
Update the patch.
Comment 9 niklas.nebel 2009-05-05 18:08:38 UTC 
What I had in mind was to change the behavior only if the output table would
otherwise overwrite its source data. With the patch, the output is only ever
moved down, never up.

If there is space available, it's intended behavior to add page fields or the
filter button above the existing table, so the data area of the output starts at
the same position as before.
Comment 10 yonggang.mao 2009-05-07 05:02:02 UTC 
Created attachment 62062 [details]
Update the patch.
Comment 11 niklas.nebel 2009-05-07 15:33:05 UTC 
The check if the new area is editable and empty, and the CopyToDocument call for
undo must be done with the changed output area.
Comment 12 yonggang.mao 2009-05-11 03:34:21 UTC 
Created attachment 62152 [details]
Update the patch again.
Comment 13 yonggang.mao 2009-05-15 04:56:18 UTC 
Created attachment 62279 [details]
Update the patch.
Comment 14 niklas.nebel 2009-05-19 21:33:25 UTC 
"pOutput->SetPosition" should be after CreateOutput. pOutput is set because of
GetNewOutputRange, but ScDPObject::Output shouldn't rely on that.

More importantly, the new position for aNewOut is wrong. In the example, if the
output is originally at A22 instead of A23, data is still overwritten. Also, you
should check if aNewOut is still valid and not outside of the sheet.
Comment 15 yonggang.mao 2009-05-20 15:49:37 UTC 
Created attachment 62394 [details]
Update the patch.
Comment 16 niklas.nebel 2009-05-27 13:30:41 UTC 
taking the issue
Comment 17 niklas.nebel 2009-05-27 13:32:30 UTC 
I added the last patch to CWS "calc50".
Comment 18 niklas.nebel 2009-05-28 15:21:45 UTC 
reassigning to QA for verification
Comment 19 oc 2009-06-08 14:18:27 UTC 
verified in internal build cws_calc50
Comment 20 amy2008 2009-07-10 04:06:10 UTC 
Verified in DEV300m51
Closing