Issue 24203 - rotate data labels
Summary: rotate data labels
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: PC Windows 2000
: P3 Trivial with 17 votes (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL: http://specs.openoffice.org/chart/Cha...
Keywords: ms_interoperability, rfe_eval_ok
: 31742 (view as issue list)
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2004-01-08 09:34 UTC by huvo
Modified: 2013-02-24 21:18 UTC (History)
8 users (show)

See Also:
Issue Type: FEATURE
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
picture of the enhancement (14.53 KB, image/png)
2004-01-08 09:36 UTC, huvo 		no flags Details
patch_0809016 (16.66 KB, text/plain)
2008-09-16 10:15 UTC, weiz 		no flags Details
example (30.29 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-09-22 14:00 UTC, IngridvdM 		no flags Details
patch_081022 (21.81 KB, patch)
2008-10-22 08:43 UTC, weiz 		no flags Details | Diff
example for rotated pie labels (39.74 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-02-10 17:11 UTC, IngridvdM 		no flags Details
patch_090318 (7.18 KB, patch)
2009-03-18 03:20 UTC, weiz 		no flags Details | Diff
patch_090320 (7.10 KB, patch)
2009-03-24 02:35 UTC, weiz 		no flags Details | Diff
Specification (278.24 KB, application/vnd.oasis.opendocument.text)
2009-03-26 04:12 UTC, weiz 		no flags Details
Testvasespecification Rotate Data Labels (19.53 KB, text/html)
2009-05-27 17:31 UTC, kla 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description huvo 2004-01-08 09:34:36 UTC 
Hi !

It would be a nice enhancement if you could rotate data columns label like the
title of chart. (text direction in degrees)
Since my english  isn't so good, I will attach a png to show what I mean.
In this png-picture I 'rotated' the data columns label (155) with gimp.
It would be nice if you could do this with OOo, like you can rotate the title.

Bye,
Dominik Di Lorenzo
(dilorenzo@vogelsang-bandstahl.de)
Comment 1 huvo 2004-01-08 09:36:42 UTC 
Created attachment 12347 [details]
picture of the enhancement
Comment 2 kla 2004-02-09 10:41:44 UTC 
Hi Bettina,
one for You.
tk
Comment 3 bettina.haberer 2004-11-29 18:17:48 UTC 
Reassigned to Ingrid.
Comment 4 IngridvdM 2005-02-23 13:12:06 UTC 
Yes, we should do this. It is missing functionality compared with similar products.
Comment 5 IngridvdM 2005-02-23 13:13:40 UTC 
*** Issue 31742 has been marked as a duplicate of this issue. ***
Comment 6 IngridvdM 2005-04-19 10:08:19 UTC 
added keyword
Comment 7 IngridvdM 2005-04-26 09:20:33 UTC 
changed summary a little for better readability
Comment 8 IngridvdM 2008-07-22 14:21:32 UTC 
reset to new
Comment 9 weiz 2008-09-16 10:15:12 UTC 
Created attachment 56562 [details]
patch_0809016
Comment 10 weiz 2008-09-16 10:17:05 UTC 
@iha: the patch is submitted, please let me know your suggestions. Thanks.
I will extend the specification "ChartDataLabels.odt" if the patch is OK.
Comment 11 kpalagin 2008-09-16 14:13:06 UTC 
Rail,
please see attached patch by weiz.
Comment 12 rail_ooo 2008-09-18 15:38:48 UTC 
It worked fine for me, wel done, weiz!

Set type to PATCH.
Comment 13 IngridvdM 2008-09-22 13:57:54 UTC 
@weiz, the patch looks quite good already, but there are a few problems:
-The position of the rotated labels is not correct in all cases. Dependent on
placement type and rotation the labels get a wrong offset. I'll attach a
document to show the problem. Especially vertically rotated labels in a column
chart (a major use case of this feature) do not have a correct position. Please
try to correct the position dependent on the rotation and alignment. I think we
have a similar correction for the axes label positions already (see
lcl_correctPositionForRotation).
-Is there a reason why you hide the new rotation control within the Data Labels
dialog? I think it is worth to be shown there also.
-When the legend key is displayed within the data labels the text is not rotated.
Thanks, Ingrid.
Comment 14 IngridvdM 2008-09-22 14:00:01 UTC 
Created attachment 56714 [details]
example
Comment 15 weiz 2008-10-22 08:43:29 UTC 
Created attachment 57373 [details]
patch_081022
Comment 16 weiz 2008-10-22 08:48:00 UTC 
@iha: the new patch is attached. :-)
Comment 17 IngridvdM 2009-02-10 17:01:39 UTC 
@weiz, as discussed in our weekly IRC meeting I modified the second patch and
commited it to CWS chart37. Please join the CWS to work on this issue further as
there is still something to do. In detail:
In dev300m38 there was an additional control 'text direction' integrated to the
labels tab page. This makes a different layout more suitable. I changed it
accordingly. Further the duplication of the functionality
lcl_correctPositionForRotation was unlucky in the patch. To avoid that I added
one new parameterizeable method LabelPositionHelper::correctPositionForRotation
for that purpose. But there are still some special cases not implemented. For
pie charts the labels can have a 'corner alignment' (left-top, right-bottom
...). Those need special treatment. I have added some 'todos' in the code at the
relevant places. Please have a look! I'll attach an example document that shows
the problematic cases. Thanks, Ingrid.
Comment 18 IngridvdM 2009-02-10 17:11:58 UTC 
Created attachment 60072 [details]
example for rotated pie labels
Comment 19 weiz 2009-03-18 03:20:41 UTC 
Created attachment 60999 [details]
patch_090318
Comment 20 weiz 2009-03-18 03:21:44 UTC 
@iha, I cannot submit the code via SVN, maybe I need to resubmit my key to ask
for the write access. :)
The patch is attached, please let me know your suggestions.
Thank you!
Comment 21 IngridvdM 2009-03-18 15:20:35 UTC 
@weiz, the labels should not overlap the pie. You can see this error with a
rotation of 15 degree for example or 105 degree or 195 ... . Please try to avoid
that.
Comment 22 weiz 2009-03-24 02:35:02 UTC 
Created attachment 61135 [details]
patch_090320
Comment 23 weiz 2009-03-24 02:37:07 UTC 
@iha, the new patch is attached, hope it works well. :)
Comment 24 IngridvdM 2009-03-24 11:32:34 UTC 
@weiz, thanks. I commited the patch to CWS chart37. Now the specification still
needs to be updated.
Comment 25 weiz 2009-03-26 04:12:20 UTC 
Created attachment 61200 [details]
Specification
Comment 26 weiz 2009-03-26 04:17:44 UTC 
@iha, the updated specification is attached.
I am unfamiliar with the new control "text direction", so I think you should add
the detail of this control to the specification. Thank you!
Comment 27 IngridvdM 2009-03-26 15:02:42 UTC 
The spec is submitted and an email is send to the i-team - waiting for feedback now.
http://specs.openoffice.org/chart/ChartDataLabels.odt
Comment 28 daniel.rentz 2009-04-08 13:27:07 UTC 
I'm doing the XLS/XLSX import/export bits.
Comment 29 daniel.rentz 2009-04-08 15:20:43 UTC 
characters cannot be stacked, is this intended? It is possible in "other" apps...
Comment 30 IngridvdM 2009-04-08 15:25:58 UTC 
@dr, that is a different feature that is not targeted with this issue.
Comment 31 daniel.rentz 2009-04-09 09:53:38 UTC 
Import from BIFF5, BIFF8, OOXML added
Export to BIFF8 added
Comment 32 IngridvdM 2009-04-09 13:43:54 UTC 
Feedback from i-team was positive->fixed.
Created issue 100987 to update the automatic tests.
Comment 33 IngridvdM 2009-04-28 09:44:42 UTC 
@kla, please verify in CWS chart37.
Comment 34 kla 2009-05-27 17:31:18 UTC 
Created attachment 62595 [details]
Testvasespecification Rotate Data Labels
Comment 35 kla 2009-05-27 17:32:08 UTC 
Issue verified in CWS chart37, TCS written
Comment 36 kla 2009-07-24 13:33:04 UTC 
Integrated into master -> closed