Issue 120629 - Performance improvement for loading xls file with several Pivot Tables. SOT optimization
Summary: Performance improvement for loading xls file with several Pivot Tables. SOT o...
Status: CONFIRMED
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: 3.4.0
Hardware: All All
: P3 Major (vote)
Target Milestone: 4.0.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 03:23 UTC by Zhang Lu
Modified: 2012-12-03 14:22 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch for SOT optimization (6.75 KB, patch)
2012-09-12 08:32 UTC, Tan Li 		no flags Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Zhang Lu 2012-08-21 03:23:10 UTC 
It is slow to load or save a big xls file, which contain several pivot tables, need improved.
Comment 1 binguo 2012-08-29 01:46:58 UTC 
Verified on Aoo_Trunk_20120828.1800, it can repro, change status from "uncomfirmed" to "confirmed".
Comment 2 Tan Li 2012-09-12 08:32:37 UTC 
Created attachment 79427 [details]
patch for SOT optimization

SOT optimization for DataPilot
Comment 3 Tan Li 2012-09-12 08:58:36 UTC 
Root causes:
StgCache and Stgpage manage two lists which are of little use but will cause frequent memory page fault.

Solutions:
Don't use the two lists, but only use member pLRUCache of class StgCache to process cache update. This greatly simplify StgCache creation when DataPilot import.
Comment 4 Tan Li 2012-09-12 12:01:10 UTC 
The two lists, StgPage* pCur and StgPage* pElem1, only play a role in StgCache::Commit(...); in other member methods, it waste lots of efficiency.
Comment 5 Tan Li 2012-12-03 14:22:30 UTC 
Comment on attachment 79427 [details]
patch for SOT optimization

Sorry for some late doubts, needing more experiments.