Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | rotate data labels | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | General | Reporter: | huvo <dilorenzo> | ||||||||||||||||||||
Component: | chart | Assignee: | kla <thomas.klarhoefer> | ||||||||||||||||||||
Status: | CLOSED FIXED | QA Contact: | issues@graphics <issues> | ||||||||||||||||||||
Severity: | Trivial | ||||||||||||||||||||||
Priority: | P3 | CC: | daniel.rentz, IngridvdM, issues, jr, pagalmes.lists, rail_ooo, tony.galmiche.ooo, weizhao | ||||||||||||||||||||
Version: | 3.3.0 or older (OOo) | Keywords: | ms_interoperability, rfe_eval_ok | ||||||||||||||||||||
Target Milestone: | --- | ||||||||||||||||||||||
Hardware: | PC | ||||||||||||||||||||||
OS: | Windows 2000 | ||||||||||||||||||||||
URL: | http://specs.openoffice.org/chart/ChartDataLabels.odt | ||||||||||||||||||||||
Issue Type: | FEATURE | Latest Confirmation in: | --- | ||||||||||||||||||||
Developer Difficulty: | --- | ||||||||||||||||||||||
Issue Depends on: | |||||||||||||||||||||||
Issue Blocks: | 72764 | ||||||||||||||||||||||
Attachments: |
|
Description
huvo
2004-01-08 09:34:36 UTC
Created attachment 12347 [details]
picture of the enhancement
Hi Bettina, one for You. tk Reassigned to Ingrid. Yes, we should do this. It is missing functionality compared with similar products. *** Issue 31742 has been marked as a duplicate of this issue. *** added keyword changed summary a little for better readability reset to new Created attachment 56562 [details]
patch_0809016
@iha: the patch is submitted, please let me know your suggestions. Thanks. I will extend the specification "ChartDataLabels.odt" if the patch is OK. Rail, please see attached patch by weiz. It worked fine for me, wel done, weiz! Set type to PATCH. @weiz, the patch looks quite good already, but there are a few problems: -The position of the rotated labels is not correct in all cases. Dependent on placement type and rotation the labels get a wrong offset. I'll attach a document to show the problem. Especially vertically rotated labels in a column chart (a major use case of this feature) do not have a correct position. Please try to correct the position dependent on the rotation and alignment. I think we have a similar correction for the axes label positions already (see lcl_correctPositionForRotation). -Is there a reason why you hide the new rotation control within the Data Labels dialog? I think it is worth to be shown there also. -When the legend key is displayed within the data labels the text is not rotated. Thanks, Ingrid. Created attachment 56714 [details]
example
Created attachment 57373 [details]
patch_081022
@iha: the new patch is attached. :-) @weiz, as discussed in our weekly IRC meeting I modified the second patch and commited it to CWS chart37. Please join the CWS to work on this issue further as there is still something to do. In detail: In dev300m38 there was an additional control 'text direction' integrated to the labels tab page. This makes a different layout more suitable. I changed it accordingly. Further the duplication of the functionality lcl_correctPositionForRotation was unlucky in the patch. To avoid that I added one new parameterizeable method LabelPositionHelper::correctPositionForRotation for that purpose. But there are still some special cases not implemented. For pie charts the labels can have a 'corner alignment' (left-top, right-bottom ...). Those need special treatment. I have added some 'todos' in the code at the relevant places. Please have a look! I'll attach an example document that shows the problematic cases. Thanks, Ingrid. Created attachment 60072 [details]
example for rotated pie labels
Created attachment 60999 [details]
patch_090318
@iha, I cannot submit the code via SVN, maybe I need to resubmit my key to ask for the write access. :) The patch is attached, please let me know your suggestions. Thank you! @weiz, the labels should not overlap the pie. You can see this error with a rotation of 15 degree for example or 105 degree or 195 ... . Please try to avoid that. Created attachment 61135 [details]
patch_090320
@iha, the new patch is attached, hope it works well. :) @weiz, thanks. I commited the patch to CWS chart37. Now the specification still needs to be updated. Created attachment 61200 [details]
Specification
@iha, the updated specification is attached. I am unfamiliar with the new control "text direction", so I think you should add the detail of this control to the specification. Thank you! The spec is submitted and an email is send to the i-team - waiting for feedback now. http://specs.openoffice.org/chart/ChartDataLabels.odt I'm doing the XLS/XLSX import/export bits. characters cannot be stacked, is this intended? It is possible in "other" apps... @dr, that is a different feature that is not targeted with this issue. Import from BIFF5, BIFF8, OOXML added Export to BIFF8 added Feedback from i-team was positive->fixed. Created issue 100987 to update the automatic tests. @kla, please verify in CWS chart37. Created attachment 62595 [details]
Testvasespecification Rotate Data Labels
Issue verified in CWS chart37, TCS written Integrated into master -> closed |