one for the requirements team

OpenOffice.org Issue Tracker - Feedback Request.

The Issue you raised is currently assigned to 'Requirements' pending review, but
has not been updated within the last 3 years. Please consider re-testing with
one of the latest versions of OOo, as the problem(s) may have already been
addressed. Either use the recent stable version:
http://download.openoffice.org/index.html
or consider trying the new OOo 3 BETA (still in testing):
http://download.openoffice.org/3.0beta/
 
Please report back the outcome so this Issue may be Closed or Progressed as
necessary - otherwise it may be Resolved as Invalid in the future. You may also
wish to search for (and note) any duplicates of this Issue that may have
advanced further by checking the Issue Tracker:
http://www.openoffice.org/issues/query.cgi
 
Many thanks,
Andrew
 
Cleaning-up and Closing old Issues as part of:
~ The Grand Bug Squash, pre v3 ~
http://marketing.openoffice.org/3.0/announcementbeta.html

Checked version 3.0 beta.  Alt+= doesn't do anything, and can't be assigned. 
The "auto-sum" button doesn't appear as a function that can be assigned to a hot
key.

If the "auto-sum" (as I call it) button could be assigned a shortcut, that would
be cool.

*** Issue 95685 has been marked as a duplicate of this issue. ***

Created attachment 78216 [details]
Make auto sum can be executed by dispatch framework

This patch move and migrate auto sum function from ScInputWindow to ScTabViewShell class. 
"Sum" entry with sum icon is added to "Edit" category of the customize dialog. 
Help entry for .uno:AutoSum command is not included in this patch. 

Alt + "=" is not assign-able now, it is required to be improved.

(In reply to comment #5)
> Created attachment 78216 [details]
> Make auto sum can be executed by dispatch framework
> 
> This patch move and migrate auto sum function from ScInputWindow to
> ScTabViewShell class. 
> "Sum" entry with sum icon is added to "Edit" category of the customize
> dialog. 
> Help entry for .uno:AutoSum command is not included in this patch. 
> 
> Alt + "=" is not assign-able now, it is required to be improved.

For the images, I guess you can reuse
default_images/sc/res/imglst/apptbx/[sc|sch|lc|lch]26048.png
http://svn.apache.org/viewvc/incubator/ooo/trunk/main/default_images/sc/res/imglst/apptbx/lc26048.png?view=co&content-type=text%2Fplain

Simply *copy* them:

default_images/sc/res/imglst/apptbx/sc26048.png   ->  default_images/res/commandimagelist/sc_autosum.png
default_images/sc/res/imglst/apptbx/lc26048.png   ->  default_images/res/commandimagelist/lc_autosum.png
default_images/sc/res/imglst/apptbx/sch26048.png  ->  default_images/res/commandimagelist/sch_autosum.png
default_images/sc/res/imglst/apptbx/lch26048.png  ->  default_images/res/commandimagelist/lch_autosum.png

Or even better, *move* them (this saves having duplicated icons); this will be more work: you will have to modify the source code to use the UNO command to retrieve the image, instead of the slot ID
Some hints (didn't try them, so they might not work):
in sc/source/ui/app/inputwin.cxx, instead of the SfxImageManager, try 
Image SAL_CALL GetImage( const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XFrame >& rFrame, const ::rtl::OUString& aURL, sal_Bool bBig, sal_Bool bHiContrast ) 
in sfx2/source/appl/imagemgr.cxx

(In reply to comment #6)
> For the images, I guess you can reuse
> default_images/sc/res/imglst/apptbx/[sc|sch|lc|lch]26048.png
> http://svn.apache.org/viewvc/incubator/ooo/trunk/main/default_images/sc/res/
> imglst/apptbx/lc26048.png?view=co&content-type=text%2Fplain
Writer and Draw have .uno:AutoSum command and its icons are there in res/commandimagelist, they are used for command added by this patch because of I choose the same command name.
I want to leave to migrate images for time to resolve input window to normal toolbar elements.

Created attachment 78236 [details]
Accelerator, help and fix when input window is hidden

When input window is not shown, the formula is inserted the way used by Function List window. 
ADD, SUBTRACT, MULTIPLY, DIVIDE, POINT, COMMA, and EQUAL keys with modifier keys are added to customize dialog. 
Some of them are not work well, they are depends on user's keyboard layout. 
Alt + "=" is assigned by this patch and it works with US keyboard layout but 
it does not work with ja-106 layout. Because "=" requires shift key to push on ja-106.

(In reply to comment #7)
> > For the images, I guess you can reuse
> > default_images/sc/res/imglst/apptbx/[sc|sch|lc|lch]26048.png
> > http://svn.apache.org/viewvc/incubator/ooo/trunk/main/default_images/sc/res/
> > imglst/apptbx/lc26048.png?view=co&content-type=text%2Fplain
> Writer and Draw have .uno:AutoSum command and its icons are there in
> res/commandimagelist, 

You are right, they are there (what a duplication of icons, then)

> they are used for command added by this patch because
> of I choose the same command name.

Then please, don't add the Label to CalcCommands.xcu, this way translators will have to translate the same string in three places.

Remove the command from DrawImpressCommands.xcu and WriterCommands.xcu, and add it (omit the German translation) to GenericCommands.xcu (this file should contain commands that are used in more than one application, as long as it makes sense to have the same label - for example, that's not the case with ".uno:SendMailDocAsMS", it has a different label according to the application).

I'll open an issue to remove all the other commands that are duplicated (they are quit a lot).

> I want to leave to migrate images for time to resolve input window to normal
> toolbar elements.

Yes, it would be nice to use UNO commands everywhere.

Created attachment 78237 [details]
Simple document to test autosum

The document attached to reduce to check the patch. 
AutoSum should be the same behavior with the auto sum of AOO 3.4, compare following behaviors between them.
ScTabViewShell::InputAutoSum function is separated into two parts. 
1. Cell or cell ranges are selected.
- Select C4:D4, autosum -> C4: =SUM(C1:C3) and D4: =SUM(D1:D3)
- Select F1:G4, autosum -> A2:G5 selected and G5: =SUM(G2:G4)
- Select C9:C11, -> each rows should be summed
- Select D9:D11, -> D11: =SUM(), this is ScViewFunc::AutSum returns false.
- Put cell cursor on E14 -> E14: =SUBTOTAL(9;E9:E13) for filtered range

2. No cell selected, else section of first if statement.
- Put cell cursor on A6, autosum -> A6 shows =SUM(A1:A5) and it can be canceled

Un-check View - Formula Bar to hide input window and try above situations, 
the same results should be shown in cell edit window or directly inputted.

Created attachment 78238 [details]
The command move to GenericCommands

> > they are used for command added by this patch because
> > of I choose the same command name.
> 
> Then please, don't add the Label to CalcCommands.xcu, this way translators
> will have to translate the same string in three places.
Then, attached.

I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob

"Alt +" still does not work as a substitute for the Sum Button in Apache OpenOffice 4.0.1.  In fact I do not even know if there is a menu item for the Sum button.  It seems very careless to create buttons whose effect cannot be reproduced by hand.

(In reply to peterinscotland from comment #13)
> "Alt +" still does not work as a substitute for the Sum Button in Apache
> OpenOffice 4.0.1.  In fact I do not even know if there is a menu item for
> the Sum button.  It seems very careless to create buttons whose effect
> cannot be reproduced by hand.

+1 Why not make the autosum button like any other one? movable, menu-able, toolbar-able, icon-able, shortcut-able...