Issue 1163 - title for secondary y axis
Summary: title for secondary y axis
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial with 18 votes (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL: http://specs.openoffice.org/chart/Cha...
Keywords: ms_interoperability, rfe_eval_ok
: 56682 71730 77633 84855 (view as issue list)
Depends on:
Blocks: 72764 85164
  Show dependency tree
 
Reported: 2001-07-03 21:05 UTC by issues@www
Modified: 2017-04-07 08:06 UTC (History)
11 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch (9.71 KB, text/plain)
2007-09-20 03:12 UTC, weiz
no flags Details
new patch (10.59 KB, text/plain)
2007-10-10 03:43 UTC, weiz
no flags Details
specification (95.97 KB, text/plain)
2007-10-10 03:43 UTC, weiz
no flags Details
specification (86.42 KB, text/plain)
2007-10-15 03:32 UTC, weiz
no flags Details
patch 3 with further corrections and still open issues (14.25 KB, application/x-compressed)
2007-10-22 20:48 UTC, IngridvdM
no flags Details
patch_issue1163_1115 (13.30 KB, text/plain)
2007-11-15 06:31 UTC, weiz
no flags Details
TCS_Title_for_secondary_axes (19.24 KB, text/html)
2008-02-12 09:12 UTC, kla
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description issues@www 2001-07-03 21:05:53 UTC
it isn't possible to set the title on the second axis (i need a true second 
axis that is independent of the first y axis , to represent different data)
Comment 1 frank 2001-07-04 09:21:31 UTC
.
Comment 2 issues@www 2001-07-29 14:59:50 UTC
what do you think of that?

 eg: -on x axis,i've the time
     -on first y axis i've the price of the oil
     -on the second y axis , i've the price of the wood

So i need two y axis because the range of the price is very different.

Comment 3 falko.tesch 2001-10-10 17:48:30 UTC
I will get back to this issue asap
Comment 4 Unknown 2001-11-08 22:36:05 UTC
changing QA contact from bugs@ to issues@
Comment 5 Unknown 2002-06-04 18:09:55 UTC
I was going to start my own issue, but I think that the comments here
and my need are closely related. It would be nice to plot two columns
with respect to each other. For example, I want point 1 to be
(A:1,B:1) point 2 to be (A:2,B:2) all the way down. Now all I can get
is (1,A:1),(2,A:2), etc.
Comment 6 falko.tesch 2003-10-08 09:26:37 UTC
Re-assigned to Matthia Müller-Prove for further evaluation.
Comment 7 matthias.mueller-prove 2003-10-08 17:37:04 UTC
to Bettina, our central dispatcher for RFEs
Comment 8 bettina.haberer 2004-01-19 16:37:20 UTC
Hello Matthias, please consider this Chart-RFE also for the Q (OO.o 2.0). BTW
this miising feature has been experienced also internally.
Comment 9 matthias.mueller-prove 2004-03-17 16:38:26 UTC
changed summary
Comment 10 matthias.mueller-prove 2004-07-19 15:07:30 UTC
set target to OOo Later
Comment 11 kla 2005-11-03 10:42:05 UTC
*** Issue 56682 has been marked as a duplicate of this issue. ***
Comment 12 IngridvdM 2006-11-20 21:55:41 UTC
changed summary, added keywords, added me to CC
Comment 13 IngridvdM 2006-11-20 21:56:51 UTC
*** Issue 71730 has been marked as a duplicate of this issue. ***
Comment 14 tony.galmiche.ooo 2007-05-26 13:10:35 UTC
I confirm this problem with OOo 2.3 m213
Comment 15 IngridvdM 2007-05-31 19:30:57 UTC
*** Issue 77633 has been marked as a duplicate of this issue. ***
Comment 16 weiz 2007-09-20 03:11:33 UTC
Hi bm,

The attached is the patch for this issue.
I make the patch as a package, because it contains a new idl file.
If you have any suggestion for the patch, please let me know. Thanks a lot.

Best Regards,
Weizhao
Comment 17 weiz 2007-09-20 03:12:59 UTC
Created attachment 48352 [details]
patch
Comment 18 weiz 2007-10-10 03:41:50 UTC
Hi bm,

The new patch of this issue is completed, and the final attachment is the 
specification.
Please let me know your suggestion. Thank you very much.
Comment 19 weiz 2007-10-10 03:43:22 UTC
Created attachment 48795 [details]
new patch
Comment 20 weiz 2007-10-10 03:43:59 UTC
Created attachment 48796 [details]
specification
Comment 21 weiz 2007-10-15 03:31:26 UTC
Hi bm,

The attached file is the specification of menu structure.
Thanks for your suggestion and other useful information in your last email. 
I'll do it better.
Thank you very much.
Comment 22 weiz 2007-10-15 03:32:14 UTC
Created attachment 48886 [details]
specification
Comment 23 IngridvdM 2007-10-16 07:56:17 UTC
Thanks for the patch and the specification. There are still a couple of issues
to solve.
1) Regarding the UI strings: In the menu we already use 'Secondary X Axis' so I
think the according title should be called 'Secondary X Axis Title'. You have
done this in the string STR_OBJECT_TITLE_SECONDARY_X_AXIS, but the menu and the
title dialog is inconsistent. At least the menu should be changed to become
consistent. Hm, with the title dialog there will probably be a space/layout
problem, when using the lengthy wording 'secondary'. I would suggest to use a
heading 'Secondary axes title' for the both additional edit fields and then skip
'2nd'. I will ask MMP for input on this but he is on vacation this week.
2) The patch has a compilation conflict with a more up to date master (231) with
the ResourceIds. You can avoid this by using the IDs 87 and 88 for
STR_OBJECT_TITLE_SECONDARY_X_AXIS and STR_OBJECT_TITLE_SECONDARY_Y_AXIS.
3) The patch has a conflict during applying it on a more up to date master
because one of the changed files was renamed:
chart2/source/controller/dialogs/res_Titles.src is renamed to res_Titlesx_tmpl.hrc
4) We will get duplicate used HelpIds for HID_SCH_TITLE_SECONDARY_X and
HID_SCH_TITLE_SECONDARY_Y when CWS chart14 gets integrated. This needs to be
checked manually again before commiting.
5) Regarding the title dialog specification: For the new controls it says 
'Enabled, If the current chart supports a secondary x axis' .But I think the
implementation is like: 'Enabled, if the current chart has a secondary x axis'.
This inconsistency should be resolved.
6) Formatting issue: All the date formats in the specifiction documents are
corrupted somehow. Please keep in mind that the documents are english.
7) Pixel issue: The space at the bottom of the title dialog is to small.
8) Variable naming issue: The new parameter 'bShow' at the title resources
should state more precisely what it is supposed to influence. Please call it
bShowSecondaryAxisTitles or similar.
...more next time
But you are on the right way!
Comment 24 IngridvdM 2007-10-22 20:42:40 UTC
->weiz: I talked to MMP and the final strings should be 'Secondary X Axis Title'
for the menu and 'Secondary x axis' for the fixed text in the dialog (without
heading). I already did the according changes to the resources (see attached
patch), but the specifications needs to be updated still. I put some more
intelligence into the positioning of the dialogs fixed texts and edit fields
thus they now use the given space optimal depending on the local dependent strings.
I also did correct all the above mentioned issues except point 5 and 6.
And I found another problem with your patch:
In the chart view you removed the titles from the model, that are currently not
supported by the chart type. This is strictly forbidden! The view is for
creating a visual representation only, the view is absolutely not allowed to
change the model! I removed the wrong code and corrected it for the x axes title
as an example. Please correct it for the y and z axis title also.
The new patch is for a more recent version >= SRC680m226.

weiz, the following issues have still to be done:
1) Don't create shapes for unsupported y and z titles in the chart view
2) Allow to insert titles for the secondary axes when they are supported by the
chart type (so far the axis need to exist, but that criteria is to restrictive)
3) Change the specifications according to the final strings and correct the
wrong formatting
4) Thoroughly test the new feature
Comment 25 IngridvdM 2007-10-22 20:48:20 UTC
Created attachment 49079 [details]
patch 3 with further corrections and still open issues
Comment 26 IngridvdM 2007-10-25 08:02:15 UTC
adjusting target
Comment 27 weiz 2007-11-15 06:30:20 UTC
->iha, bm: The new patch for this issue is submitted. Please find the final 
attachment. Please let me know if I miss anything.
Comment 28 weiz 2007-11-15 06:31:34 UTC
Created attachment 49665 [details]
patch_issue1163_1115
Comment 29 IngridvdM 2007-11-19 21:24:06 UTC
->weiz: Thanks for the patch. I will integrate it into CWS chart19.
One thing of common interest may be:
When introducing new menu items it is not necessary to set extra help ids
anymore. This feature is deprecated. For some of the old menu entries the help
id numbers are still in use especially in the test tool environment but in
future only the UNO commands itself will be used for help or test tool access.
So I removed menu:helpid=... from the both new menu items:
<menu:menuitem menu:id=".uno:SecondaryXTitle" menu:label="" />
<menu:menuitem menu:id=".uno:SecondaryYTitle" menu:label="" />.
There were some other minor issues I will send you separate mail for.
Comment 30 IngridvdM 2007-11-21 12:24:20 UTC
Fixed in CWS chart19.
The changes for the specifications are online:
http://specs.openoffice.org/chart/ChartInsertTitleDialog.odt
http://specs.openoffice.org/chart/menus/MenuStructure.odt 
Comment 31 kla 2007-12-27 06:57:24 UTC
*** Issue 84855 has been marked as a duplicate of this issue. ***
Comment 32 IngridvdM 2008-01-11 10:37:29 UTC
->Thomas, please verify in CWS chart19.
The im- and export to xcel will be addressed with a separate issue 85164.
Comment 33 kla 2008-02-12 09:12:18 UTC
Created attachment 51470 [details]
TCS_Title_for_secondary_axes
Comment 34 kla 2008-02-12 10:21:30 UTC
Verified in CWS chart19
Comment 35 kla 2008-06-17 10:02:19 UTC
Seen ok in current master -> closed
Comment 36 eduardojrobledo 2008-11-29 19:45:39 UTC
Although there is a menu item for the editing of the secondary axes title, there
is no way to have a secondary axes title to edit, so the menu item is not available.
There are two ways to create a secondary axis:
- edit a data series and in "options" align it to the secondary axis, or,
- insert a secondary axis
Neither way a title for the secondary axis is created.

Ooo 3.0 Windows Vista.
Comment 37 eduardojrobledo 2008-11-29 19:51:00 UTC
Sorry for the last report. I have found that i can insert a secondary axes title
under the insert title menu. It is obious... :(