Issue 84546

Summary: Modification of List Styles shows a wrong string the undo menu
Product: Writer Reporter: eric.savary
Component: uiAssignee: eric.savary
Status: CLOSED FIXED QA Contact: issues@sw <issues>
Severity: Trivial    
Priority: P3 CC: chengxiuzhi, issues, liujiaxiang, liuyu
Version: 680m238   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 72764    
Attachments:
Description Flags
patchfile
none
patch file none

Description eric.savary 2007-12-13 15:42:58 UTC 
The fix of issue 82689 lets a wrong string in the undo menu appear.

- open the "Styles and Formatting" window (if not already open)
- switch to "List Styles"
- right-click "Numbering 1" "Modify..."
- change anything here, for example apply a bullet
-> The undo menu shows "Insert Numbering". It should be "Change numbering style:
<style_name>"
Comment 1 liuyu 2008-02-20 08:54:41 UTC 
Created attachment 51601 [details]
patchfile
Comment 2 liuyu 2008-02-20 09:22:21 UTC 
liuy->ama:
Please have a look at the patch, I don't know how to modify the localize.sdf 
file, so I have not added other languages source of the STR_CHGNUM.
Comment 3 andreas.martens 2008-02-20 10:03:30 UTC 
ama->liuyu: You do not need to change the localize.sdf. It sufficient to insert
English text into resources. The localization process will be started
automatically by inserting your text into a database which will be translated
later on.
But two other remarks: 
You can simply replace UNDO_REPLACE_DUMMY_6 with your new STR_CHGNUM and leave
the other dummies (UNDO_REPLACE_DUMMY_7 .. _9 ) unchanged.
You can insert a placeholder ($1) into the string to be able to display the name
of the style in the undo string.
Comment 4 liuyu 2008-02-21 07:49:55 UTC 
Created attachment 51620 [details]
patch file
Comment 5 liuyu 2008-02-21 07:51:03 UTC 
liuy->ama:
Please have a look at the new patch file.
Comment 6 andreas.martens 2008-02-21 10:58:58 UTC 
ama->liuyu:
There are some minor things like use of "22" instead of UNDO_INSNUM and a
virtual method declared as inline. But nevertheless I will integrate your patch
with a few changes in one of our next CWS.
Thank you for your patch!
Comment 7 andreas.martens 2008-03-06 15:05:54 UTC 
Fixed in CWS sw30bf02
undo.hrc
undo.src
undobj.hxx
swundo.hxx
unnum.cxx
docnum.cxx
Comment 8 andreas.martens 2008-03-19 12:36:42 UTC 
I've reworked the fix a little bit to avoid resource changes.
Undo display: "Change style: <NameOfStyle>"
Fixed in CWS sw30bf02.
Comment 9 andreas.martens 2008-03-26 10:56:28 UTC 
Ready for QA
Comment 10 eric.savary 2008-03-28 14:01:36 UTC 
Verified in cws sw30bf02
Comment 11 sgautier.ooo 2009-02-01 13:49:40 UTC 
Verified in DEV300_m40 .deb version - closing - Sophie