Issue 69281

Summary: Make chart2 warning-free on Windows and Linux
Product: General Reporter: Stephan Bergmann <stephan.bergmann.secondary>
Component: chartAssignee: Stephan Bergmann <stephan.bergmann.secondary>
Status: CLOSED FIXED QA Contact: issues@graphics <issues>
Severity: Trivial    
Priority: P3 CC: issues, tony.galmiche.ooo, yonggang.mao
Version: 3.3.0 or older (OOo)   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: TASK Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 72764    
Attachments:
Description Flags
The patch for i69281#
none
The patch for i69281#
none
The patch file is only a part of chart2 modules about i69281# none

Description Stephan Bergmann 2006-09-05 15:43:27 UTC 
Please make module chart2 warning-free, see
<http://wiki.services.openoffice.org/wiki/Writing_warning-free_code>.

This issue probably depends on the integration of
<http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Id=4120&Path=SRC680%2Fsb59>
(as then the headers delivered from all the modules roughly up to svx should be
warning-free).

It is intended to fix this issue latest in the OOo version following OOo 2.1, so
that the complete OOo C/C++ code base will be warning-free by then.
Comment 1 bjoern.milcke 2006-11-21 12:57:33 UTC 
We will start to take care about this issue after the chart2mst3 CWS has been
integrated. So, we will probably do the warning-freeness of chart2 in Mid of 2007.
Comment 2 yonggang.mao 2007-06-22 09:21:47 UTC 
Created attachment 46168 [details]
The patch for i69281#
Comment 3 yonggang.mao 2007-06-25 08:35:56 UTC 
Created attachment 46227 [details]
The patch for i69281#
Comment 4 yonggang.mao 2007-07-10 08:15:50 UTC 
Created attachment 46668 [details]
The patch file is only a part of chart2 modules about i69281#
Comment 5 bjoern.milcke 2007-07-11 11:47:18 UTC 
Applied the patch in CWS chart07 and did some more small warning fixes there.
Comment 6 bjoern.milcke 2007-07-11 13:04:34 UTC 
fixed valarray in stlport to suppress warnings. (Is used in
chart2/source/tools/InternalDataProvider.cxx) in CWS chart07.
Comment 7 bjoern.milcke 2007-07-11 18:13:43 UTC 
Windows is ready!

Checked wntmsci10, wntmsci10.pro and wntmsci10 with debug=t option.

Removed chart2 from the list of warning projects in solenv/inc/wntmsci10.mk file.
Comment 8 bjoern.milcke 2007-07-11 18:18:56 UTC 
Forgot to mention: Windows is now warning free, and warnings are treated as
errors in CWS chart07
Comment 9 bjoern.milcke 2007-07-12 10:21:43 UTC 
For remaining warnings on Solaris see Issue 79522 .

Fixed in CWS chart07
Comment 10 bjoern.milcke 2007-07-16 10:06:31 UTC 
Verified as the last build was successful on wntmsci10, wntmsci10.pro, unxlngi6
and unxlngi6.pro
Comment 11 bjoern.milcke 2007-07-16 12:52:55 UTC 
One addition for the verification:

On Linux the compilation command line contains -Wall, on Windows it contains -WX.
Comment 12 bjoern.milcke 2007-07-31 10:49:54 UTC 
On m223 chart2 is removed from the MODULES_WITH_WARNINGS list on unxlngi6 and
wntmsci10, so warnings=>errors is on for chart2. As the build finished (and I
didn't get a call from release-engineering), I supposed this issue can be closed.

->SB: Please confirm and close.
Comment 13 Stephan Bergmann 2007-08-06 08:52:16 UTC 
.